Skip to content

[REF,FIX] Revision of the resource monitor #2285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Nov 29, 2017
Merged

[REF,FIX] Revision of the resource monitor #2285

merged 21 commits into from
Nov 29, 2017

Conversation

oesteban
Copy link
Contributor

  • Allow to reuse a resource monitor file (e.g. when we reuse a partially cached work directory), with accompanying new nipype option.
  • Add a new [monitoring] section to the Nipype config file, simplified option names and updated option deprecation logic to allow for new sections.
  • Allow for changing the default summary file with all the profiling traces.

@oesteban
[FIX] Do not break when building profiling summary
e50226e 
Throw a warning instead.
@oesteban
enable reuse of resource_monitor.json, write it in base_dir
d7a2d16
@oesteban
Merge branch 'fix/resource-monitor-file' into fix/resource-monitor-re…
58b4905 
…visions
@oesteban
Merge remote-tracking branch 'upstream/master' into fix/resource-moni…
75cb366 
…tor-revisions
@oesteban
allow disable resource_monitor appending with nipype option
b72f9aa
@oesteban
allow disable resource_monitor appending with nipype option (amend to…
cd46847 
… last commit)
@oesteban
improving documentation of new config entry
8e79259
@oesteban
add new [monitoring] section to nipype config
afa63dc
@oesteban
read new monitoring.summary_file option
0100135
@oesteban
Merge remote-tracking branch 'upstream/master' into fix/resource-moni…
b159b01 
…tor-revisions
@oesteban
fix tests
612ed03
@oesteban
[skip ci] clean header up, fix two pep8 warnings
be7f6b4
@oesteban
Copy link
Contributor Author

Tests passing https://circleci.com/gh/oesteban/nipype/714

@oesteban oesteban requested a review from satra November 16, 2017 02:16
@mgxd
Copy link
Member

mgxd commented Nov 21, 2017 •
edited
Loading

Are we trying to get this in for 0.14? If so, pinging @satra for review

@oesteban
Copy link
Contributor Author

Yes, this would be nice to have in 0.14

@oesteban oesteban added this to the 0.14.0 milestone Nov 22, 2017
@oesteban
Copy link
Contributor Author

@satra, this would be the last thing before releasing 0.14.0 - isn't it?

@satra satra merged commit 6a57e3e into nipy:master Nov 29, 2017
@oesteban oesteban deleted the fix/resource-monitor-revisions branch November 29, 2017 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@satra satra Awaiting requested review from satra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.14.0
Development

Successfully merging this pull request may close these issues.
3 participants
@oesteban @mgxd @satra