Rework UnixAddr to fix soundness issues #1496
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coolreader18
force-pushed
the
encapsulate-unixaddr
branch
from
a986fdd to
50b9507
Compare
asomers
requested changes
Aug 22, 2021
coolreader18
force-pushed
the
encapsulate-unixaddr
branch
from
50b9507 to
ef4055b
Compare
asomers
reviewed
Aug 22, 2021
coolreader18
force-pushed
the
encapsulate-unixaddr
branch
2 times, most recently
from
644e725 to
28515b0
Compare
Contributor
Author
|
I also just changed the documentation of |
Contributor
Author
|
@asomers could you take a look? |
coolreader18
force-pushed
the
encapsulate-unixaddr
branch
from
28515b0 to
460842a
Compare
asomers
requested changes
Aug 28, 2021
Member
asomers
left a comment
asomers
left a comment
There was a problem hiding this comment.
Changing the meaning of len in sockaddr_storage_to_addr is a big deal. Can you make that backwards compatible instead?
coolreader18
force-pushed
the
encapsulate-unixaddr
branch
from
460842a to
8e963a0
Compare
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1494
I went with making
sun_pathalways nul-terminated since that just seems to make things easier, since (at least according to linux man pages)sockaddr_uns returned by the kernel will always be nul-terminated.