Bump MSRV to 1.63 for I/O safety #1862
Conversation
SUPERCILEX
force-pushed
the
msrv
branch
3 times, most recently
from
d96ea77 to
703f946
Compare
|
Needs a rebase. |
|
Is there any way we can use |
|
Some clippy lints I applied were false positives that needed the 2021 edition, so I bumped us up to that. |
|
#1861 should be merged first because clippy changed stuff in the code we're deleting. |
SUPERCILEX
force-pushed
the
msrv
branch
2 times, most recently
from
85fd3a3 to
e425507
Compare
|
Unrelated CI failure |
asomers
left a comment
asomers
left a comment
There was a problem hiding this comment.
It looks like the OSX build failed because it tried to download cargo-hack exactly as that project uploaded a new release.
.cirrus.yml
Outdated
| setup_script: | ||
| - rustup target add $TARGET | ||
| - rustup component add clippy | ||
| - rustup toolchain install $TOOLCHAIN --profile minimal --target $TARGET |
There was a problem hiding this comment.
I copied this from the other setup_script blocks. If you remove this I'm pretty sure the build fails with a wrong rust version error.
There was a problem hiding this comment.
And yet the old version didn't fail. I think this section is masking some other problem.
.cirrus.yml
Outdated
| TOOL: cargo | ||
| # The MSRV | ||
| TOOLCHAIN: 1.56.1 | ||
| TOOLCHAIN: 1.63 |
There was a problem hiding this comment.
Make this change and I don't think you'll need to reinstall the toolchain on line 159 below.
| TOOLCHAIN: 1.63 | |
| TOOLCHAIN: 1.63.0 |
There was a problem hiding this comment.
Sounds good, fixed.
SUPERCILEX
force-pushed
the
msrv
branch
2 times, most recently
from
6c1c5f8 to
5ea76d2
Compare
| ); | ||
|
|
||
| let ret = libc::mmap(ptr, length.into(), prot.bits(), flags.bits(), fd, offset); | ||
| let ptr = |
There was a problem hiding this comment.
There's more formatting changes like this mixed in with content changes. Can you please move them into separate commits?
There was a problem hiding this comment.
I thought this was due to the edition bump, but it looks like this is because I'm on nightly? When I run a cargo fmt on master this stuff changes. Created #1909
1909: More annoying formatting changes r=asomers a=SUPERCILEX Extracted from #1862 Co-authored-by: Alex Saveau <[email protected]>
CHANGELOG.md
Outdated
| ([#1870](https://github.com/nix-rust/nix/pull/1870)) | ||
| - The `length` argument of `sys::mman::mmap` is now of type `NonZeroUsize`. | ||
| ([#1873](https://github.com/nix-rust/nix/pull/1873)) | ||
| - The MSRV is now 1.63 |
There was a problem hiding this comment.
Arg, you need to move this part to the top of the file.
Signed-off-by: Alex Saveau <[email protected]>
Signed-off-by: Alex Saveau <[email protected]>
Signed-off-by: Alex Saveau <[email protected]>
Signed-off-by: Alex Saveau <[email protected]>
3 participants
Prep for #1750