Skip to content

Add unistd::close_range() #2153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cpick wants to merge 5 commits into from
Closed

Add unistd::close_range() #2153

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
82d3c02
Add `unistd::close_range()`
Sep 29, 2023
5a380d4
Add `close_range` PR link to changelog
Oct 4, 2023
46bd488
Add a double-close warning to `close_range()`
Oct 4, 2023
3e5d881
Mark `close_range` I/O unsafe
Oct 5, 2023
6129a9e
Add `# Safety` to `close_range`
Oct 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Mark close_range I/O unsafe 
#2153 (comment)
  • Loading branch information
Chris Pick committed Oct 5, 2023
commit 3e5d88108d100b0c8f8483a4871d21d323eed1e1
6 changes: 3 additions & 3 deletions src/unistd.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1124,7 +1124,7 @@ libc_bitflags! {
/// use nix::unistd::{close_range, CloseRangeFlags};
///
/// let f = tempfile::tempfile().unwrap();
/// close_range(f.as_raw_fd(), f.as_raw_fd(), CloseRangeFlags::empty()).unwrap(); // Bad! f will also close on drop!
/// unsafe { close_range(f.as_raw_fd(), f.as_raw_fd(), CloseRangeFlags::empty()).unwrap() }; // Bad! f will also close on drop!
/// ```
///
/// ```rust
Expand All @@ -1133,10 +1133,10 @@ libc_bitflags! {
///
/// let f = tempfile::tempfile().unwrap();
/// let fd = f.into_raw_fd(); // Good. into_raw_fd consumes f
/// close_range(fd, fd, CloseRangeFlags::empty()).unwrap();
/// unsafe { close_range(fd, fd, CloseRangeFlags::empty()).unwrap(); }
/// ```
#[cfg(target_os = "linux")]
pub fn close_range(
pub unsafe fn close_range(
first: RawFd,
last: RawFd,
flags: CloseRangeFlags,
Expand Down