Adding range type concept check#45
Merged
Merged
Conversation
joewpeterson
previously approved these changes
Oct 2, 2024
joewpeterson
approved these changes
Oct 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a range type concept check to the Container template on the AnyView constructor. This removes the issue on ubuntu clang (github CI compilation error) in the range-v3 removal branch.
In the error, a variant of either a reference_wrapper or AnyView needed to be created and the compiler got confused and tried to create an AnyView using a reference_wrapper, which fails because a reference_wrapper obviously does not have a begin() and end() method. Adding the concept switches off the constructor in this case, causing the compilation to no longer fail.