Fix new CI issues

docs/mkdocs/docs/api/macros/json_diagnostic_positions.md

@@ -6,11 +6,14 @@
 
 This macro enables position diagnostics for generated JSON objects.
 
-When enabled, two new properties: `start_pos()` and `end_pos()` are added to `nlohmann::basic_json` objects and fields. `start_pos()` returns the start position of
-that JSON object/field in the original string the object was parsed from. Likewise, `end_pos()` returns the end position of that JSON object/field in the
-original string the object was parsed from.
-
-`start_pos()` returns the first character of a given element in the original JSON string, while `end_pos()` returns the character following the last character. For objects and arrays, the first and last characters correspond to the opening or closing braces/brackets, respectively. For fields, the first and last character represent the opening and closing quotes or the first and last character of the field's numerical or predefined value (true/false/null), respectively.
+When enabled, two new properties: `start_pos()` and `end_pos()` are added to `nlohmann::basic_json` objects and fields. `start_pos()` returns the start 
+position of that JSON object/field in the original string the object was parsed from. Likewise, `end_pos()` returns the end position of that JSON
+object/field in the original string the object was parsed from.
+
+`start_pos()` returns the first character of a given element in the original JSON string, while `end_pos()` returns the character following the last
+character. For objects and arrays, the first and last characters correspond to the opening or closing braces/brackets, respectively. For fields, the first
+and last character represent the opening and closing quotes or the first and last character of the field's numerical or predefined value
+(true/false/null), respectively.
 
 Given the above, `end_pos() - start_pos()` for an object or field provides the length of the string representation for that object or field, including the
 opening or closing braces, brackets, or quotes.

include/nlohmann/detail/input/json_sax.hpp

@@ -751,12 +751,16 @@ class json_sax_dom_callback_parser
                     break;
                 }
 
+                // As we handle the start and end positions for values before calling the callback
+                // we do not expect this to be called.
+                // LCOV_EXCL_START
                 case value_t::discarded:
                 {
                     v.end_position = std::string::npos;
                     v.start_position = v.end_position;
                     break;
                 }
+                // LCOV_EXCL_STOP
                 case value_t::binary:
                 case value_t::number_integer:
                 case value_t::number_unsigned:
@@ -772,11 +776,13 @@ class json_sax_dom_callback_parser
                     // skip setting the values here.
                     break;
                 }
+                // LCOV_EXCL_START
                 default:
                 {
                     // Handle all possible types discretely, default handler should never be reached.
-                    JSON_ASSERT(false); // NOLINT(cert-dcl03-c,hicpp-static-assert,misc-static-assert,-warnings-as-errors)
+                    JSON_ASSERT(false); // NOLINT(cert-dcl03-c,hicpp-static-assert,misc-static-assert,-warnings-as-errors) // LCOV_EXCL_LINE
                 }
+                    // LCOV_EXCL_STOP
             }
         }
     }

include/nlohmann/json.hpp

@@ -1225,8 +1225,8 @@ class basic_json // NOLINT(cppcoreguidelines-special-member-functions,hicpp-spec
         : json_base_class_t(std::forward<json_base_class_t>(other)),
           m_data(std::move(other.m_data)) // cppcheck-suppress[accessForwarded] TODO check
 #if JSON_DIAGNOSTIC_POSITIONS
-        , start_position(other.start_position)
-        , end_position(other.end_position)
+        , start_position(other.start_position) // cppcheck-suppress[accessForwarded] TODO check
+        , end_position(other.end_position) // cppcheck-suppress[accessForwarded] TODO check
 #endif
     {
         // check that passed value is valid

single_include/nlohmann/json.hpp

@@ -9277,12 +9277,16 @@ class json_sax_dom_callback_parser
                     break;
                 }
 
+                // As we handle the start and end positions for values before calling the callback
+                // we do not expect this to be called.
+                // LCOV_EXCL_START
                 case value_t::discarded:
                 {
                     v.end_position = std::string::npos;
                     v.start_position = v.end_position;
                     break;
                 }
+                // LCOV_EXCL_STOP
                 case value_t::binary:
                 case value_t::number_integer:
                 case value_t::number_unsigned:
@@ -9298,11 +9302,13 @@ class json_sax_dom_callback_parser
                     // skip setting the values here.
                     break;
                 }
+                // LCOV_EXCL_START
                 default:
                 {
                     // Handle all possible types discretely, default handler should never be reached.
-                    JSON_ASSERT(false); // NOLINT(cert-dcl03-c,hicpp-static-assert,misc-static-assert,-warnings-as-errors)
+                    JSON_ASSERT(false); // NOLINT(cert-dcl03-c,hicpp-static-assert,misc-static-assert,-warnings-as-errors) // LCOV_EXCL_LINE
                 }
+                    // LCOV_EXCL_STOP
             }
         }
     }
@@ -21060,8 +21066,8 @@ class basic_json // NOLINT(cppcoreguidelines-special-member-functions,hicpp-spec
         : json_base_class_t(std::forward<json_base_class_t>(other)),
           m_data(std::move(other.m_data)) // cppcheck-suppress[accessForwarded] TODO check
 #if JSON_DIAGNOSTIC_POSITIONS
-        , start_position(other.start_position)
-        , end_position(other.end_position)
+        , start_position(other.start_position) // cppcheck-suppress[accessForwarded] TODO check
+        , end_position(other.end_position) // cppcheck-suppress[accessForwarded] TODO check
 #endif
     {
         // check that passed value is valid