Make class loader more roboust in the face of weird path/file name characters. #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I guess you could use "file:".lenght() and "!/".length() instead to make the meaning of 5 and 2 clearer. But since I didn't comment on this last time I'll let it fly :)
There was a problem hiding this comment.
I was slightly surprised at that, actually. :)
|
+2. I'd like to see the cross platform results for that file name. |
…aracters. Prefer URI over URLEncoder/URLDecoder.
|
@phyrex1an Not sure if the backslash will fly on platforms with DOS ancestry, would be interested to see. |
argggh
added a commit
that referenced
this pull request
Jun 3, 2014
Make class loader more roboust in the face of weird path/file name characters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prefer URI over URLEncoder/URLDecoder.