Skip to content

feat: add support for yarn installations #560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
targos merged 28 commits into from
Nov 24, 2018
Merged

feat: add support for yarn installations #560

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
a68825d
feat: add support for yarn installations
SimenB Apr 15, 2018
6e901eb
chore: install yarn on Travis CI
SimenB Apr 16, 2018
2714b8a
PR feedback
SimenB Oct 23, 2018
126ce60
explicitly add yarn to `$PATH`
SimenB Oct 23, 2018
6a7013e
fix spawning of yarn process
SimenB Oct 24, 2018
8904db1
add tests
SimenB Oct 24, 2018
c5dbdaa
skip failing tests
SimenB Oct 24, 2018
9ced83d
Update lib/package-manager/test.js
targos Oct 24, 2018
5cb839f
Revert "skip failing tests"
SimenB Oct 24, 2018
190877f
remove invalid test for yarn
SimenB Oct 24, 2018
938fec5
install yarn from npm
SimenB Oct 24, 2018
9352ad6
extract package manager finder to separate module
SimenB Oct 24, 2018
84c73cf
don't install yarn in .travis.yml
SimenB Oct 24, 2018
3becd4d
name function [skip ci]
SimenB Oct 24, 2018
b6f99c1
fix find when bin is not in PATH
targos Oct 24, 2018
61f3b3d
run custom test script and try to add yarn to path
SimenB Oct 24, 2018
fb3ea5a
remove custom test script
SimenB Oct 24, 2018
ede6a95
fix tests
SimenB Oct 24, 2018
99df018
remove uknown flag from yarn call
SimenB Oct 24, 2018
4e4cfa6
stringify buffers in test
SimenB Oct 25, 2018
6829ba8
tweak assertion
SimenB Oct 25, 2018
013b093
chore: rename file
SimenB Nov 18, 2018
8f7795b
rename exported function
SimenB Nov 21, 2018
261d246
simplify calling pkg manager install and test
SimenB Nov 21, 2018
9bb22dc
cache package manager binary lookup
SimenB Nov 21, 2018
792e673
fix failing test
SimenB Nov 21, 2018
669492e
PR feedback
SimenB Nov 21, 2018
04964a3
lint
SimenB Nov 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert "skip failing tests" 
This reverts commit 02cb5ab.
  • Loading branch information
@SimenB
SimenB committed Nov 21, 2018
commit 5cb839f3d80d5be5c5ad0f93f5c5e871d34a3e1c
7 changes: 2 additions & 5 deletions test/npm/test-npm-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,7 @@ const os = require('os');
const path = require('path');
const fs = require('fs');

const tap = require('tap');
const test = tap.test;
const skip = tap.skip;
const test = require('tap').test;
const mkdirp = require('mkdirp');
const rimraf = require('rimraf');
const ncp = require('ncp');
Expand Down Expand Up @@ -80,8 +78,7 @@ test('npm-test: no package.json', function (t) {
});
});

// Skipped since this does not work with shell scripts
skip('npm-test: alternative test-path', function (t) {
test('npm-test: alternative test-path', function (t) {
// Same test as 'basic module passing', except with alt node bin which fails.
const nodeBinName = packageManagerTest.__get__('nodeBinName');
packageManagerTest.__set__('nodeBinName', 'fake-node');
Expand Down
7 changes: 2 additions & 5 deletions test/yarn/test-yarn-install.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,7 @@ const os = require('os');
const path = require('path');
const fs = require('fs');

const tap = require('tap');
const test = tap.test;
const skip = tap.skip;
const test = require('tap').test;
const mkdirp = require('mkdirp');
const rimraf = require('rimraf');
const ncp = require('ncp');
Expand Down Expand Up @@ -49,8 +47,7 @@ test('yarn-install: basic module', function (t) {
});
});

// Skipped because yarn does not have the same behavior.
skip('yarn-install: extra install parameters', function (t) {
test('yarn-install: extra install parameters', function (t) {
const context = makeContext.npmContext({
name: 'omg-i-pass-with-install-param',
install: ['--extra-param']
Expand Down
7 changes: 2 additions & 5 deletions test/yarn/test-yarn-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,7 @@ const os = require('os');
const path = require('path');
const fs = require('fs');

const tap = require('tap');
const test = tap.test;
const skip = tap.skip;
const test = require('tap').test;
const mkdirp = require('mkdirp');
const rimraf = require('rimraf');
const ncp = require('ncp');
Expand Down Expand Up @@ -78,8 +76,7 @@ test('yarn-test: no package.json', function (t) {
});
});

// Skipped since this does not work with shell scripts
skip('yarn-test: alternative test-path', function (t) {
test('yarn-test: alternative test-path', function (t) {
// Same test as 'basic module passing', except with alt node bin which fails.
const nodeBinName = packageManagerTest.__get__('nodeBinName');
packageManagerTest.__set__('nodeBinName', 'fake-node');
Expand Down