Skip to content

win: fix spawning npm #635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bzoz wants to merge 1 commit into from
Closed

win: fix spawning npm #635

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions lib/package-manager/install.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
const path = require('path');

const stripAnsi = require('strip-ansi');
const which = require('which').sync;

const createOptions = require('../create-options');
const spawn = require('../spawn');
Expand All @@ -12,7 +13,7 @@ function install(packageManager, context, next) {
path.join(context.path, context.module.name),
context
);
let args = ['install'];

context.emit(
'data',
'info',
Expand All @@ -27,17 +28,26 @@ function install(packageManager, context, next) {
`Using temp directory: "${options.env['npm_config_tmp']}"`
);

if (context.module.install) {
args = args.concat(context.module.install);
let nodeBin = 'node';
if (context.options.testPath) {
options.env.PATH = `${context.options.testPath}:${process.env.PATH}`;
nodeBin = which('node', {
path: options.env.PATH || process.env.PATH
Copy link
Member

@richardlau richardlau Dec 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can options.env.PATH ever not be process.env.PATH outside of this if? (i.e. does the nodeBin calculation need to occur outside of the if statement?)

});
}

const packageManagerBin =
packageManager === 'npm' ? context.npmPath : context.yarnPath;

let args = [packageManagerBin, 'install'];
if (context.module.install) {
args = args.concat(context.module.install);
}

const binDirectory = path.dirname(packageManagerBin);
options.env.PATH = `${binDirectory}:${process.env.PATH}`;

const proc = spawn(packageManagerBin, args, options);
const proc = spawn(nodeBin, args, options);
Copy link
Member

@SimenB SimenB Dec 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this still work if the package manager is a script? Say I halve aliased npm to some

#!/usr/bin/env bash

node /path/to/npm.js --log-level=silly $0

More real script - the recommended way of installing yarn on mac is through brew - and they use a script not a JS file. So node cannot execute the file. See #560 (comment)

const finish = timeout(context, proc, next, 'Install');

proc.stderr.on('data', (chunk) => {
Expand Down