Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions lib/rules/title-format.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,36 @@ module.exports = {
pass = false
}

{
const result = /^(.+?:)[^ ]/.exec(context.title)
if (result) {
context.report({
id: id
, message: 'Add a space after subsystem(s).'
, string: context.title
, line: 0
, column: result[1].length
, level: 'fail'
})
pass = false
}
}

{
const result = /\s\s/.exec(context.title)
if (result) {
context.report({
id: id
, message: 'Do not use consecutive spaces in title.'
, string: context.title
, line: 0
, column: result.index + 1
, level: 'fail'
})
pass = false
}
}

const result = /^(.+?): [A-Z]/.exec(context.title)
if (result) {
context.report({
Expand Down
63 changes: 63 additions & 0 deletions test/rules/title-format.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,63 @@
'use strict'

const test = require('tap').test
const Rule = require('../../lib/rules/title-format')
const Commit = require('gitlint-parser-node')
const Validator = require('../../')

function makeCommit(title) {
const v = new Validator()
return new Commit({
sha: 'e7c077c610afa371430180fbd447bfef60ebc5ea'
, author: {
name: 'Evan Lucas'
, email: '[email protected]'
, date: '2016-04-12T19:42:23Z'
}
, message: title
}, v)
}

test('rule: title-format', (t) => {
t.test('space after subsystem', (tt) => {
tt.plan(2)
const context = makeCommit('test:missing space')

context.report = (opts) => {
tt.pass('called report')
tt.strictSame(opts, {
id: 'title-format'
, message: 'Add a space after subsystem(s).'
, string: 'test:missing space'
, line: 0
, column: 5
, level: 'fail'
})
}

Rule.validate(context)
tt.end()
})

t.test('consecutive spaces', (tt) => {
tt.plan(2)
const context = makeCommit('test: with two spaces')

context.report = (opts) => {
tt.pass('called report')
tt.strictSame(opts, {
id: 'title-format'
, message: 'Do not use consecutive spaces in title.'
, string: 'test: with two spaces'
, line: 0
, column: 11
, level: 'fail'
})
}

Rule.validate(context)
tt.end()
})

t.end()
})