Skip to content

Conversation

@AugustinMauroy
Copy link
Member

Description

use oxc-parser instead of acorn to have better perf

Validation

Test should pass

Related Issues

No related issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run node --run test and all tests passed.
  • I have check code formatting with node --run format & node --run lint.
  • I've covered new added functionality with unit tests if necessary.

@vercel
Copy link

vercel bot commented Aug 18, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
api-docs-tooling Ready Ready Preview Aug 18, 2025 7:26am

@codecov
Copy link

codecov bot commented Aug 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.92%. Comparing base (2cce7ec) to head (74a9cfe).
⚠️ Report is 45 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #413      +/-   ##
==========================================
- Coverage   74.22%   71.92%   -2.30%     
==========================================
  Files         118      118              
  Lines       10994    11010      +16     
  Branches      696      638      -58     
==========================================
- Hits         8160     7919     -241     
- Misses       2831     3089     +258     
+ Partials        3        2       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@AugustinMauroy
Copy link
Member Author

Okay loc property isn't supported now by oxc-parser ...

Comment on lines +28 to +33
{
range: false,
lang: 'js',
astType: 'js',
sourceType: 'script',
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{
range: false,
lang: 'js',
astType: 'js',
sourceType: 'script',
}

These are all the default

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

humm yeah right. but range will need to be used since loc isn't available.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.start and .end exist on all nodes, regardless of range setting, does Github support that syntax (over L?)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.start and .end exist on all nodes, regardless of range setting

Good to know

does Github support that syntax (over L?)

any idea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants