-
Notifications
You must be signed in to change notification settings - Fork 19
feat(parser/javascript): use oxc-parser
#413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #413 +/- ##
==========================================
- Coverage 74.22% 71.92% -2.30%
==========================================
Files 118 118
Lines 10994 11010 +16
Branches 696 638 -58
==========================================
- Hits 8160 7919 -241
- Misses 2831 3089 +258
+ Partials 3 2 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Okay |
| { | ||
| range: false, | ||
| lang: 'js', | ||
| astType: 'js', | ||
| sourceType: 'script', | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| { | |
| range: false, | |
| lang: 'js', | |
| astType: 'js', | |
| sourceType: 'script', | |
| } |
These are all the default
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
humm yeah right. but range will need to be used since loc isn't available.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.start and .end exist on all nodes, regardless of range setting, does Github support that syntax (over L?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.startand.endexist on all nodes, regardless of range setting
Good to know
does Github support that syntax (over
L?)
any idea
Description
use
oxc-parserinstead ofacornto have better perfValidation
Test should pass
Related Issues
No related issues
Check List
node --run testand all tests passed.node --run format&node --run lint.