Skip to content

Conversation

@avivkeller
Copy link
Member

Windows machines use \r\n for newlines, so this PR removes the \n check from the output tests.

@avivkeller avivkeller requested a review from a team as a code owner October 12, 2025 19:10
Copilot AI review requested due to automatic review settings October 12, 2025 19:10
@vercel
Copy link

vercel bot commented Oct 12, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
api-docs-tooling Ready Ready Preview Oct 12, 2025 7:15pm

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes OS-specific test failures by making the GitHub transport logger tests agnostic to different newline formats. Windows uses \r\n while Unix systems use \n, causing test assertions to fail on Windows machines.

  • Updates test assertions to use trim() method to remove trailing whitespace and newlines
  • Removes hardcoded \n characters from expected output strings in assertions

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codecov
Copy link

codecov bot commented Oct 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.55%. Comparing base (3291812) to head (f6bf321).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #464   +/-   ##
=======================================
  Coverage   74.55%   74.55%           
=======================================
  Files         107      107           
  Lines       10466    10467    +1     
  Branches      684      683    -1     
=======================================
+ Hits         7803     7804    +1     
  Misses       2661     2661           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ovflowd ovflowd merged commit 3fd0072 into main Oct 14, 2025
19 checks passed
@ovflowd ovflowd deleted the os-agnostic-tests branch October 14, 2025 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants