Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! rename to cleanup
  • Loading branch information
RafaelGSS committed Aug 13, 2024
commit 8f0ae6284ca1d1d760149a399350394bf40b5fe0
16 changes: 8 additions & 8 deletions components/git/security.js
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,8 @@ const securityOptions = {
describe: 'Create the post-release announcement',
type: 'boolean'
},
finish: {
describe: 'Finish the security release.',
cleanup: {
describe: 'cleanup the security release.',
type: 'boolean'
}
};
Expand Down Expand Up @@ -86,8 +86,8 @@ export function builder(yargs) {
'git node security --post-release',
'Create the post-release announcement on the Nodejs.org repo'
).example(
'git node security --finish',
'Finish the security release. Merge the PR and close H1 reports'
'git node security --cleanup',
'Cleanup the security release. Merge the PR and close H1 reports'
);
}

Expand Down Expand Up @@ -119,8 +119,8 @@ export function handler(argv) {
if (argv['post-release']) {
return createPostRelease(argv);
}
if (argv.finish) {
return finishSecurityRelease(argv);
if (argv.cleanup) {
return cleanupSecurityRelease(argv);
}
yargsInstance.showHelp();
}
Expand Down Expand Up @@ -177,11 +177,11 @@ async function startSecurityRelease() {
return release.start();
}

async function finishSecurityRelease() {
async function cleanupSecurityRelease() {
const logStream = process.stdout.isTTY ? process.stdout : process.stderr;
const cli = new CLI(logStream);
const release = new PrepareSecurityRelease(cli);
return release.start();
return release.cleanup();
}

async function syncSecurityRelease(argv) {
Expand Down
2 changes: 1 addition & 1 deletion lib/prepare_security.js
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ export default class PrepareSecurityRelease extends SecurityRelease {
this.cli.ok('Done!');
}

async finish() {
async cleanup() {
const credentials = await auth({
github: true,
h1: true
Expand Down