Skip to content
This repository was archived by the owner on Jul 31, 2018. It is now read-only.

ep: ws in core #6

Closed
wants to merge 2 commits into from
Closed

ep: ws in core #6

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
815c620
ep: ws in core
eljefedelrodeodeljefe Jan 25, 2016
dd2b60c
weaker wording
eljefedelrodeodeljefe Jan 25, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions 003-ws-in-core.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
| Title | ws in core |
|--------|-----------------------------|
| Author | @eljefedelrodeodeljefe |
| Status | DRAFT |
| Date | 2015-01-25 02:34:00 |

## Description

This EP proposes having the current [websockets/ws](https://github.com/websockets/ws) userland implementation in core.
Efforts have already been made on nodejs/node#4842. It is understood that
adaptions to style and simplicity need to be done in order to conform with
`node` core.

## Motivation

> `websockets` are the primary reason for companies, which have **not** decided
to make a commitment towards `node` to use `node` anyways. For a wider adoption
of the language this is a critical point.
Copy link

@Fishrock123 Fishrock123 Jan 25, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How much basis is there for this? My insight indicates to me: little to none..

Copy link
Author

@eljefedelrodeodeljefe eljefedelrodeodeljefe Jan 25, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...me as an engineering manager in a PHP-shop.

Copy link
Author

@eljefedelrodeodeljefe eljefedelrodeodeljefe Jan 25, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could change wording, but I think this fact still hold up.

Copy link
Member

@ChALkeR ChALkeR Jan 25, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I highly doubt that this is a valid point. Without performing some kind of relevant research, at least.

Copy link

@feross feross Feb 1, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If companies are already adopting node.js because of how good the ws package is, then that means the ws maintainers are doing a great job and there's nothing that node core needs to do.


The above statement is the observation of the author.

However in order to gain momentum as a language, the experience should be as
performant, secure and well documented as possible. Userland development is to
be believed not holding enough capacity to meet those requirements. Especially
issues like `Buffer(number)`, however dangerous they are, can only be
effectively secured via backporting code through the language's LTS.

## Note

This document is in progress.