Skip to content

gyp: vendor in GYP3 6.0.3 #1845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

gyp: vendor in GYP3 6.0.3 #1845

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f2d3053
gyp: vendor in GYP3 6.0.4
refack Jul 24, 2019
2eb4d2b
meta: more generic .gitignore
refack Jul 26, 2019
555e399
config: fix syntax error in addon.gypi
refack Jul 26, 2019
b9afb43
test: better logging for test/test-addon.js
refack Jul 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
config: fix syntax error in addon.gypi
  • Loading branch information
@refack
refack committed Jul 26, 2019
commit 555e3991648731a320df7bfe5e7094e075a1db91
14 changes: 6 additions & 8 deletions addon.gypi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,6 @@
'win_delay_load_hook': 'true',
'product_prefix': '',

'conditions': [
[ 'node_engine=="chakracore"', {
'variables': {
'node_engine_include_dir%': 'deps/chakrashim/include'
},
}]
],

'include_dirs': [
'<(node_root_dir)/include/node',
'<(node_root_dir)/src',
Expand Down Expand Up @@ -89,6 +81,12 @@
],

'conditions': [
[ 'node_engine=="chakracore"', {
'variables': {
'node_engine_include_dir%': 'deps/chakrashim/include'
},
}],

[ 'OS=="mac"', {
'defines': [
'_DARWIN_USE_64_BIT_INODE=1'
Expand Down