resource leak in http.js

[quexer]

Here're codes from "Agent.prototype.removeSocket" in http.js

...

  if (this.sockets[name]) {
    var index = this.sockets[name].indexOf(s);
    if (index !== -1) {
      this.sockets[name].splice(index, 1);
    }
  } else if (this.sockets[name] && this.sockets[name].length === 0) {
    // don't leak
    delete this.sockets[name];
    delete this.requests[name];
  }

...

The "else if" branch is unreachable.

[koichik]

@quexer: Thanks for the report, good catch!

Can someone review koichik/node@aeaa36a?

[bnoordhuis]

@koichik: LGTM

[koichik]

@bnoordhuis Thanks, merging.

[koichik]

@quexer Thanks for the report, fixed in 7aa5924.

[quexer]

@koichik thanks

[ry]

thanks @koichik

[lloyd]

Sorry for being lazy, but would this patch affect leak seen when agent: false, or is it only pertinent to http requests performed when the global connection pooling "agent" is in use?

[bnoordhuis]

@lloyd: This patch only affects connection pooling. If you experience resource leaks with {agent:false}, can you open an issue with a test case?

[lloyd]

thanks @bnoordhuis, I'll try to distill a minimal test case and will open a diff bug if I succeed.