Skip to content
This repository was archived by the owner on Apr 22, 2023. It is now read-only.
This repository was archived by the owner on Apr 22, 2023. It is now read-only.

crypto, tls: fix code duplication #6024

@bnoordhuis

Description

@bnoordhuis

Commit 03e008d introduces src/tls_wrap.cc but it does so by massively copy/pasting from src/node_crypto.cc.

I want to see that fixed before v0.12. I can live with a little duplication but having almost 1,000 lines of nearly identical code is a bloody maintenance nightmare.

If v0.12 is an unrealistic target, I'll revert the change and we'll retry it for v0.14.

Assigning to you, @indutny.

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions