Skip to content
This repository was archived by the owner on Apr 22, 2023. It is now read-only.

Deprecate RC4 ciphers from the default ciphers list #25603

Closed
misterdjules wants to merge 16 commits into from
Closed

Deprecate RC4 ciphers from the default ciphers list #25603

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
cc935a2
tls: disable RC4, add --cipher-list command line switch
jasnell Apr 2, 2015
09e9430
tls: make the --enable-legacy-cipher-list help less verbose
jasnell Apr 6, 2015
1006b28
tls: order of precedence on cipher list options, type checking
jasnell Apr 23, 2015
ead952d
test: test-tls-cipher-list test error type
jasnell Apr 23, 2015
8687086
test: fix typo in tls.markdown doc and additional tests
jasnell Apr 28, 2015
0793970
tls: refactor test-tls-cipher-list and v0.10.38 legacy test
jasnell May 1, 2015
dfead0d
test: additional refinements in the test
jasnell May 5, 2015
d852445
test: additional round of edits on the test-tls-cipher-list.js
jasnell May 9, 2015
014912c
test: refactor default cipher list test
jasnell May 12, 2015
1c25456
tls: fix default ciphers not used consistently
Apr 28, 2015
56e7970
test: backport fix ssl/tls options matrix test
Jan 14, 2015
d7a4ca5
test: update ssl options matrix tests
Jun 30, 2015
cebce08
cryto: don't set default ciphers if client uses 10.38 legacy cipher
Jun 30, 2015
9783a82
tls,crypto: small refactoring for legacy ciphers
Jul 16, 2015
bd74d90
tls,crypto: update default cipher list version numbers
Jul 16, 2015
ca77bae
src: fix warnings about cipher lists
Jul 16, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: test-tls-cipher-list test error type 
test that the type of error thrown is correct
  • Loading branch information
@jasnell
jasnell authored and Julien Gilli committed Jul 16, 2015
commit ead952d27879c0bdd5a2956f25cf707119c22652
8 changes: 4 additions & 4 deletions test/simple/test-tls-cipher-list.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,12 +106,12 @@ doTest(V1038Ciphers, 'v0.10.38', 8);
});

// invalid value
assert.throws(function() {tls.getLegacyCiphers('foo');});
assert.throws(function() {tls.getLegacyCiphers('foo');}, Error);
// no parameters
assert.throws(function() {tls.getLegacyCiphers();});
assert.throws(function() {tls.getLegacyCiphers();}, TypeError);
// not a string parameter
assert.throws(function() {tls.getLegacyCiphers(1);});
assert.throws(function() {tls.getLegacyCiphers(1);}, TypeError);
// too many parameters
assert.throws(function() {tls.getLegacyCiphers('abc', 'extra');});
assert.throws(function() {tls.getLegacyCiphers('abc', 'extra');}, TypeError);
// ah, just right
assert.doesNotThrow(function() {tls.getLegacyCiphers('v0.10.38');});