Skip to content
This repository was archived by the owner on Apr 22, 2023. It is now read-only.

Conversation

refack
Copy link
Contributor

@refack refack commented Aug 7, 2017

@vsemozhetbyt
Copy link

vsemozhetbyt commented Aug 7, 2017

May be we could also mention nodejs/help with distinction described? It would be a bit harsh if somebody is redirected twice with an issue like #26596

@refack
Copy link
Contributor Author

refack commented Aug 7, 2017

Anyone know what's the policy for landing in this repo?

Copy link
Member

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a suggestion.

@refack You can just land it, nothing out of the ordinary.

@@ -0,0 +1,2 @@
Thank you for your pull request. This repository has been archived.
Please open the PR in https://github.com/nodejs/node/compare
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just https://github.com/nodejs/node? The compare view won't work if the changes are in a fork of this repo.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went with https://github.com/nodejs/node/pulls for as much focusing as possible 🤷‍♂️

Copy link

@Fishrock123 Fishrock123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some bolding wouldn't hurt, doesn't matter too much though.

@Fishrock123
Copy link

Also yes, there is no rules for landing stuff here other than "usually don't except for redirection purposes" :P

@refack
Copy link
Contributor Author

refack commented Aug 8, 2017

Some bolding wouldn't hurt, doesn't matter too much though.

since it shows up as monotype, best we can do is some ASCII art

screenshot of node's new issue form
image

@gibfahn gibfahn merged commit 2a73a6a into nodejs:moved Aug 12, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants