Skip to content
This repository was archived by the owner on Apr 22, 2023. It is now read-only.

Conversation

mscdex
Copy link

@mscdex mscdex commented May 29, 2013

The parent fill() just returns undefined, so return something more useful for chaining purposes instead.

@trevnorris
Copy link

The return value should come from Buffer::Fill. Just return args.This(). I'm on the fence about the change.

/cc @isaacs

@mscdex
Copy link
Author

mscdex commented May 29, 2013

Wouldn't that return a reference to the parent and not the slice?

@trevnorris
Copy link

ah yeah, you're right. but that will change once #4964 lands.

@bnoordhuis
Copy link
Member

Landed in 6af8788, thanks.

@bnoordhuis bnoordhuis closed this May 30, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants