Skip to content
This repository was archived by the owner on Apr 22, 2023. It is now read-only.

lib: introduce .setMaxSendFragment(size) #6900

Closed
wants to merge 4 commits into from
Closed

lib: introduce .setMaxSendFragment(size) #6900

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
027b16d
lib: introduce `.setMaxSendFragment(size)`
indutny Jan 17, 2014
9687f32
doc: fixes
indutny Jan 18, 2014
028076e
fixes
indutny Jan 20, 2014
dd5a82c
add test coverage
indutny Jan 20, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
doc: fixes
  • Loading branch information
@indutny
indutny committed Jan 18, 2014
commit 9687f321a1175bd6a06eaddaf5200c7d78ec0130
10 changes: 9 additions & 1 deletion doc/api/tls.markdown
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -629,7 +629,15 @@ with an error after `handshakeTimeout` timeout.

### tlsSocket.setMaxSendFragment(size)

Set maximum TLS fragment size (default value is: `16384`).
Set maximum TLS fragment size (default and maximum value is: `16384`, minimum
is: `512`). Returns `true` on success, `false` otherwise.
Copy link

@tjfontaine tjfontaine Jan 20, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add test coverage on this part? Is there an upper bound?

Copy link
Member Author

@indutny indutny Jan 20, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep 16384, will add test tomorrow.

Copy link
Member Author

@indutny indutny Jan 20, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added test coverage.


Smaller fragment size decreases buffering latency on the client: large
fragments are buffered by the TLS layer until the entire fragment is received
and its integrity is verified; large records can span multiple roundtrips, and
their processing can be delayed due to packet loss or reordering. However,
smaller record size adds extra TLS framing bytes and CPU overhead, which may
decrease overall server throughput.

### tlsSocket.address()

Expand Down