Skip to content
Closed
Changes from 1 commit
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
436afed
doc: update README for node-v8 repository
nodejs-ci Mar 8, 2020
51acddb
deps: update V8 to 8.2.0
nodejs-ci Mar 8, 2020
50a6724
build: reset embedder string to "-node.0"
nodejs-ci Mar 8, 2020
4cf01f0
tools: update V8 gypfiles for 8.1
mmarchini Mar 5, 2020
56cb21e
deps: update V8 dtrace & postmortem metadata
cjihrig Oct 15, 2019
c193ed8
deps: V8: un-cherry-pick bd019bd
refack Mar 27, 2019
415c8b3
deps: patch V8 to run on older XCode versions
ryzokuken Sep 14, 2019
4f4195a
deps: V8: patch register-arm64.h
refack May 22, 2019
43c2180
deps: V8: forward declaration of `Rtl*FunctionTable`
refack May 22, 2019
95925f9
deps: make v8.h compatible with VS2015
joaocgreis Nov 1, 2019
d2477d2
Revert "assert: fix line number calculation after V8 upgrade"
targos Dec 6, 2019
4a05ead
deps: bump minimum icu version to 65
targos Jan 6, 2020
45f9e6c
deps: V8: cherry-pick 1e36e21acc40
mmarchini Mar 6, 2020
665c55d
deps: include right headers in torque output
gengjiawen Feb 27, 2020
2578bf3
src: stop overriding deprecated V8 methods
backes Dec 2, 2019
f6d0a92
src: remove use of deprecated Symbol::Name()
cjihrig Dec 14, 2019
bd569a6
src: avoid calling deprecated method
backes Feb 3, 2020
40c39c6
src: remove deprecated wasm type check
backes Feb 6, 2020
5b82c61
test: remove checks for deserializing wasm
mmarchini Mar 6, 2020
446d460
test: remove test
backes Feb 6, 2020
d9c4fad
test: mark inspector tests as flaky
mmarchini Mar 4, 2020
591b4d2
src: migrate measureMemory to new v8 api
gengjiawen Mar 4, 2020
81c1703
tools: update V8 gypfiles
targos Feb 11, 2020
428c444
tools: update v8 gypfiles
targos Feb 14, 2020
4efd8f0
tools: update v8 gypfiles
targos Feb 27, 2020
91b70ff
Rename FinalizationGroup to FinalizationRegistry
syg Feb 24, 2020
13fb00a
deps: revert postmortem metadata floating patch
mmarchini Mar 8, 2020
1e24bf6
build: update V8 gypfiles
mmarchini Mar 8, 2020
4f5d403
v8: remove deprecated method
gengjiawen Mar 6, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
src: remove use of deprecated Symbol::Name()
This commit replaces Symbol::Name() with
Symbol::Description().

Fixes: nodejs/node#30916
  • Loading branch information
cjihrig authored and nodejs-ci committed Mar 8, 2020
commit f6d0a925419bbaa4fa7fde5e918f4d62da3bc3f5
8 changes: 4 additions & 4 deletions src/node_symbols.cc
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@ static void Initialize(Local<Object> target,
Local<Context> context,
void* priv) {
Environment* env = Environment::GetCurrent(context);
#define V(PropertyName, StringValue) \
target \
->Set(env->context(), env->PropertyName()->Name(), env->PropertyName()) \
.Check();
#define V(PropertyName, StringValue) \
target->Set(env->context(), \
env->PropertyName()->Description(), \
env->PropertyName()).Check();
PER_ISOLATE_SYMBOL_PROPERTIES(V)
#undef V
}
Expand Down