Skip to content

dns.promises test coverage is poor #22471

@ChALkeR

Description

@ChALkeR

Ref: #20435 (comment)

Experimental dns/promises API is present in the current master without proper test coverage.

According to the coverage report, the following functions are not tested at all:

  • onlookup
  • onlookupall
  • onlookupservice
  • createLookupServicePromise

While inspecting the experimental fs.promises, there were also some implementation bugs found that could have been caught by code coverage, see e.g. #20407. The dns.promises is much smaller in lines of code, but it is still possible that it contains bugs that could be noticed by extending coverage.

Metadata

Metadata

Assignees

No one assigned

    Labels

    dnsIssues and PRs related to the dns subsystem.experimentalIssues and PRs related to experimental features.promisesIssues and PRs related to ECMAScript promises.testIssues and PRs related to the tests.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions