-
-
Notifications
You must be signed in to change notification settings - Fork 33.5k
Closed
Labels
dnsIssues and PRs related to the dns subsystem.Issues and PRs related to the dns subsystem.experimentalIssues and PRs related to experimental features.Issues and PRs related to experimental features.promisesIssues and PRs related to ECMAScript promises.Issues and PRs related to ECMAScript promises.testIssues and PRs related to the tests.Issues and PRs related to the tests.
Description
Ref: #20435 (comment)
Experimental dns/promises
API is present in the current master
without proper test coverage.
According to the coverage report, the following functions are not tested at all:
onlookup
onlookupall
onlookupservice
createLookupServicePromise
While inspecting the experimental fs.promises
, there were also some implementation bugs found that could have been caught by code coverage, see e.g. #20407. The dns.promises
is much smaller in lines of code, but it is still possible that it contains bugs that could be noticed by extending coverage.
Metadata
Metadata
Assignees
Labels
dnsIssues and PRs related to the dns subsystem.Issues and PRs related to the dns subsystem.experimentalIssues and PRs related to experimental features.Issues and PRs related to experimental features.promisesIssues and PRs related to ECMAScript promises.Issues and PRs related to ECMAScript promises.testIssues and PRs related to the tests.Issues and PRs related to the tests.