test failures without openssl-cli

[shigeki]

• Version: v8.0.0-pre
• Platform: all
• Subsystem: test

When openssl-cli is not found, several tests are failed due to missing its check.

$ rm out/Release/openssl-cli
$ python tools/test.py --mode=release parallel -J
(snip)
[00:22|% 100|+ 1166|-   4]: Done

This issue is reserved to be fixed in the course of Code and Learn in Node Fest Tokyo 2016.

Ref: nodejs/code-and-learn#58

[bnoordhuis]

Is that something that really needs fixing though? It only breaks when you actively sabotage it.

[shigeki]

I think the tests would fail if Node is built with shared openssl library in which openssl-cli does not exist.

[bnoordhuis]

I understand now. That's right, it won't get built. I'd probably make openssl-cli build unconditionally rather than trying to fix up the tests.

[shigeki]

The common.opensslCli looks for external openssl command when shared library is used so that the test failure would happened in very limited case, as only libraries are installed or it does not have a path to the command.

So I think it is good to check via common.opensslCli such as other tests do now rather than to build openssl-cli even in shared library.

[shigeki]

No one worked in this issue so it is open to everyone.

[sotayamashita]

I would like to work on this one. 💪
https://github.com/sotayamashita/node/tree/feature/test-openssl-cli

[sotayamashita]

@shigeki I would like to ask a question. How to generate common/ which is required in test code.
Thanks in advance.

I miss understood and I figure it out now 😃

[sotayamashita]

Landed in 5ffb7d7.

@shigeki Could you close this issue ?

[shigeki]

@sotayamashita Thanks.