Skip to content

test: increase test coverage for cancelling timers #10068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

test: increase test coverage for cancelling timers #10068

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a5c78a2
test: increase coverage for timers
lrlna Dec 1, 2016
70da42b
fix linting errors
lrlna Dec 1, 2016
3db6789
add changes requested by @fishrock123
lrlna Dec 1, 2016
5cc4b0b
don't test clear interval twice
lrlna Dec 2, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions test/parallel/test-timers-clear-null-does-not-throw-error.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
'use strict';
require('../common');
const assert = require('assert');

// This test makes sure clearing timers with
// 'null' or no input does not throw error

assert.doesNotThrow(() => clearInterval(null));

assert.doesNotThrow(() => clearInterval());

assert.doesNotThrow(() => clearTimeout(null));

assert.doesNotThrow(() => clearTimeout());

assert.doesNotThrow(() => clearInterval(null));
Copy link
Contributor

@cjihrig cjihrig Dec 2, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason you're testing intervals twice? Should these be immediates?

Copy link
Contributor Author

@lrlna lrlna Dec 2, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you're rightttt!


assert.doesNotThrow(() => clearInterval());