inspector: fix Coverity defects #10240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
bnoordhuis
approved these changes
Dec 12, 2016
addaleax
approved these changes
Dec 12, 2016
cjihrig
approved these changes
Dec 13, 2016
ofrobots
approved these changes
Dec 13, 2016
|
Landed as 3c29b2f |
|
@Fishrock123 not sure how the bot came up with these labels... this one definitely does not land cleanly on any branch |
|
@eugeneo this does not land cleanly on It appears there are some paths on master that don't exist on v7.x |
2 tasks
Merged
evanlucas
pushed a commit
that referenced
this pull request
Jan 3, 2017
One defect remains - Coverity believes that a session object is never freed while in reality its lifespan is tied to a libuv socket. PR-URL: #10240 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ali Ijaz Sheikh <[email protected]>
evanlucas
pushed a commit
that referenced
this pull request
Jan 4, 2017
One defect remains - Coverity believes that a session object is never freed while in reality its lifespan is tied to a libuv socket. PR-URL: #10240 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ali Ijaz Sheikh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
Inspector: just minor fixes to address Coverity comments
Description of change
One defect remains - Coverity believes that a session object is never
freed while in reality its lifespan is tied to a libuv socket.