Skip to content

test: refactor test-watch-file.js #10679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sivaprs wants to merge 2 commits into from
Closed

test: refactor test-watch-file.js #10679

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f49e63e
test: refactor test-watch-file.js
sivaprs Jan 7, 2017
86fc4f9
test: refactor the code in test/pummel/test-watch-file.js
sivaprs Jan 9, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
test: refactor test-watch-file.js 
* use const and let instead of var
* use arrow function
  • Loading branch information
@sivaprs
sivaprs committed Jan 7, 2017
commit f49e63e11e1d68a8a230771197019e035d30e2a3
8 changes: 4 additions & 4 deletions test/pummel/test-watch-file.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,13 @@ const assert = require('assert');
const fs = require('fs');
const path = require('path');

var f = path.join(common.fixturesDir, 'x.txt');
const f = path.join(common.fixturesDir, 'x.txt');

console.log('watching for changes of ' + f);
Copy link
Contributor

@thefourtheye thefourtheye Jan 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please remove console.logs in this file?


var changes = 0;
let changes = 0;
function watchFile() {
fs.watchFile(f, function(curr, prev) {
fs.watchFile(f, (curr, prev) => {
console.log(f + ' change');
changes++;
assert.notDeepStrictEqual(curr.mtime, prev.mtime);
Expand All @@ -24,7 +24,7 @@ function watchFile() {
watchFile();


var fd = fs.openSync(f, 'w+');
const fd = fs.openSync(f, 'w+');
fs.writeSync(fd, 'xyz\n');
fs.closeSync(fd);

Expand Down