Fix missing negation #10712
Closed
Fix missing negation #10712
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will fix nodejs#10710 by changing `..can result in expected` to `..can result in unexpected`
nodejs-github-bot
added
doc
cjihrig
approved these changes
Jan 9, 2017
jasnell
approved these changes
Jan 9, 2017
lpinca
approved these changes
Jan 10, 2017
|
This one is small enough that it does not need to wait the full 48 hours |
jasnell
pushed a commit
that referenced
this pull request
Jan 10, 2017
Changing `..can result in expected` to `..can result in unexpected` Fixes: #10710 PR-URL: #10712 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
|
Landed in 4e8eb62. |
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 18, 2017
Changing `..can result in expected` to `..can result in unexpected` Fixes: nodejs#10710 PR-URL: nodejs#10712 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 23, 2017
Changing `..can result in expected` to `..can result in unexpected` Fixes: nodejs#10710 PR-URL: nodejs#10712 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 24, 2017
Changing `..can result in expected` to `..can result in unexpected` Fixes: nodejs#10710 PR-URL: nodejs#10712 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 27, 2017
Changing `..can result in expected` to `..can result in unexpected` Fixes: nodejs#10710 PR-URL: nodejs#10712 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Mar 7, 2017
Changing `..can result in expected` to `..can result in unexpected` Fixes: #10710 PR-URL: #10712 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 9, 2017
Changing `..can result in expected` to `..can result in unexpected` Fixes: #10710 PR-URL: #10712 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix #10710 by changing
..can result in expectedto..can result in unexpected