Revert "benchmark: fix CLI arguments check in common.js" #12474
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e34f8e1.
nodejs-github-bot
added
the
benchmark
MylesBorins
approved these changes
Apr 17, 2017
cjihrig
approved these changes
Apr 17, 2017
jasnell
added a commit
that referenced
this pull request
Apr 17, 2017
This reverts commit e34f8e1. PR-URL: #12474 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
|
Landed. |
evanlucas
pushed a commit
that referenced
this pull request
Apr 25, 2017
This reverts commit e34f8e1. PR-URL: #12474 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
evanlucas
pushed a commit
that referenced
this pull request
May 1, 2017
This reverts commit e34f8e1. PR-URL: #12474 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
evanlucas
pushed a commit
that referenced
this pull request
May 2, 2017
This reverts commit e34f8e1. PR-URL: #12474 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ugh. I goofed. I landed #12429, then realized it never went through CI and it breaks one of the tests in sequential.
This reverts commit e34f8e1.
Need to get this landed quickly so we unbreak CI
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test, benchmark