Skip to content

Dgram buffers #13623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DamienOReilly wants to merge 13 commits into from
Closed

Dgram buffers #13623

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
9d6cd42
doc: added docs for send/receive buffer sizes
DamienOReilly Jun 11, 2017
b84bf95
dgram: support for setting socket buffer size
DamienOReilly Jun 11, 2017
8aed7aa
dgram: tests for setting socket buffer size
DamienOReilly Jun 11, 2017
f7c1aa6
src: udp - support to set socket buffer sizes
DamienOReilly Jun 11, 2017
a99ec11
dgram: fixed indentation
DamienOReilly Jun 11, 2017
2581c09
dgram: added method mapping
DamienOReilly Jun 11, 2017
b0ac4ff
dgram: fixed test for os independence. fixed docs
DamienOReilly Jun 12, 2017
f6bf7f2
dgram: fixed syntax, added options support
DamienOReilly Jun 12, 2017
d5789c0
dgram: add support to get buffer sizes
DamienOReilly Jun 14, 2017
cd79a58
dgram: fixed typos in tests and docs
DamienOReilly Jun 14, 2017
de458d1
dgram: lint errors and other pr comments
DamienOReilly Jun 14, 2017
f196be9
dgram: addressing pr coments
DamienOReilly Jun 21, 2017
f4d3564
dgram: fixed buffer sizes in tests
DamienOReilly Sep 10, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
doc: added docs for send/receive buffer sizes 
setRecvBufferSize and setSendBufferSize
  • Loading branch information
@DamienOReilly
DamienOReilly committed Sep 10, 2017
commit 9d6cd42767f62938904eb4f5ad3106145a762d5a
20 changes: 20 additions & 0 deletions doc/api/dgram.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -398,6 +398,26 @@ decremented to 0 by a router, it will not be forwarded.
The argument passed to to `socket.setMulticastTTL()` is a number of hops
between 0 and 255. The default on most systems is `1` but can vary.

### socket.setRecvBufferSize(size)
<!-- YAML
Copy link
Member

@jasnell jasnell Jun 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to also include these as options when the Socket is created?

Copy link
Contributor Author

@DamienOReilly DamienOReilly Jun 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this is a good idea.

added: vx.x.x
Copy link
Contributor

@refack refack Jun 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

put REPLACEME we have a macro that fills it it

-->

* `size` {number} Integer

Sets the `SO_RCVBUF` socket option. Sets the maximum socket receive buffer
in bytes.

### socket.setSendBufferSize(size)
<!-- YAML
added: vx.x.x
Copy link
Contributor

@refack refack Jun 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

-->

* `size` {number} Integer

Sets the `SO_SNDBUF` socket option. Sets the maximum socket send buffer
in bytes.

### socket.setTTL(ttl)
<!-- YAML
added: v0.1.101
Expand Down