Skip to content

test: In test/parallel/test-https-drain.js, use fixtures.fixturesDir #15841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

test: In test/parallel/test-https-drain.js, use fixtures.fixturesDir #15841

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8527fde
use fixtures.fixturesDir
Oct 6, 2017
9d95186
use fixtures.path() instead of using fixturesDir
Oct 6, 2017
90d35fe
use fixtures.readSync
Oct 10, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions test/parallel/test-https-drain.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,17 +21,17 @@

'use strict';
const common = require('../common');
const fixtures = require('../common/fixtures');
Copy link
Member

@lpinca lpinca Oct 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: can you please move this after the common.hasCrypto check?


if (!common.hasCrypto)
common.skip('missing crypto');

const assert = require('assert');
const https = require('https');
const fs = require('fs');
const path = require('path');

const options = {
key: fs.readFileSync(path.join(common.fixturesDir, 'test_key.pem')),
cert: fs.readFileSync(path.join(common.fixturesDir, 'test_cert.pem'))
key: fixtures.readSync('test_key.pem'),
cert: fixtures.readSync('test_cert.pem')
};

const bufSize = 1024 * 1024;
Expand Down