Skip to content

Replaced https-socket-options test using fixtures #15882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Replaced https-socket-options test using fixtures #15882

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
06cf9f2
test: replaced fs.readSync with fixtures.readSync
Oct 6, 2017
949ae1b
test: optimizing the use of the fixtures library
Oct 6, 2017
1b5a460
test: fixed typo
Oct 6, 2017
1bfc2e9
[Squash] Fix nits
jasnell Oct 15, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
test: replaced fs.readSync with fixtures.readSync 
NINA 2017 Code and Learn session for first time contributors.  This
touched test/parallel/test-https-socket-options.js to replace
common.fixturesDir
  • Loading branch information
Lam Chan committed Oct 6, 2017
commit 06cf9f22aa9c80f1211f1c1b5fa74b302c43d30c
5 changes: 3 additions & 2 deletions test/parallel/test-https-socket-options.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@

'use strict';
const common = require('../common');
const fixtures = require('../common/fixtures');
Copy link
Member

@lpinca lpinca Oct 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: can you please move this after the common.hasCrypto check?


if (!common.hasCrypto)
common.skip('missing crypto');
Expand All @@ -30,8 +31,8 @@ const fs = require('fs');
const http = require('http');

const options = {
key: fs.readFileSync(`${common.fixturesDir}/keys/agent1-key.pem`),
cert: fs.readFileSync(`${common.fixturesDir}/keys/agent1-cert.pem`)
key: fixtures.readSync(`/keys/agent1-key.pem`),
Copy link
Contributor

@pawelgolda pawelgolda Oct 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be readKey method instead of readSync

cert: fixtures.readSync(`/keys/agent1-cert.pem`)
};

const body = 'hello world\n';
Expand Down