test: replacing common.fixturesDir with common.fixtures module for te… #15907
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st-tls-honorcipherorder.js
Trott
added
the
code-and-learn
Trott
approved these changes
Oct 8, 2017
There was a problem hiding this comment.
LGTM. If you want to make it a bit more concise (and IMO better), switch to using fixtures.readKey(). Docs are at https://github.com/nodejs/node/tree/master/test/common#fixtures-module. But this is also fine as it is, IMO.
|
good catch! changed it to |
Trott
approved these changes
Oct 9, 2017
jasnell
approved these changes
Oct 10, 2017
cjihrig
approved these changes
Oct 10, 2017
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Oct 11, 2017
In test-tls-honorcipherorder.js, use common.fixtures instead of common.fixturesDir. PR-URL: nodejs#15907 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
|
Landed in 1d7fbab. |
addaleax
pushed a commit
to addaleax/ayo
that referenced
this pull request
Oct 12, 2017
In test-tls-honorcipherorder.js, use common.fixtures instead of common.fixturesDir. PR-URL: nodejs/node#15907 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
targos
pushed a commit
that referenced
this pull request
Oct 18, 2017
In test-tls-honorcipherorder.js, use common.fixtures instead of common.fixturesDir. PR-URL: #15907 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 15, 2017
In test-tls-honorcipherorder.js, use common.fixtures instead of common.fixturesDir. PR-URL: #15907 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Nov 21, 2017
In test-tls-honorcipherorder.js, use common.fixtures instead of common.fixturesDir. PR-URL: #15907 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 28, 2017
In test-tls-honorcipherorder.js, use common.fixtures instead of common.fixturesDir. PR-URL: #15907 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…st-tls-honorcipherorder.js
as part of Node.js Interactive 2017, Vancouver BC, Canada
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes