Skip to content

test: update test failure output to include exit code and signal #15945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

test: update test failure output to include exit code and signal #15945

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
37f42a5
test: update test failure output to include exit code and signal
jennazee Oct 6, 2017
4fd69e2
updated line length
jennazee Oct 15, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions test/parallel/test-cluster-server-restart-none.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,19 @@ if (cluster.isMaster) {
worker1.on('listening', common.mustCall(() => {
const worker2 = cluster.fork();
worker2.on('exit', (code, signal) => {
assert.strictEqual(code, 0, 'worker2 did not exit normally');
assert.strictEqual(signal, null, 'worker2 did not exit normally');
assert.strictEqual(code, 0, `worker2 did not exit normally. exited with\
code ${code}`);
assert.strictEqual(signal, null, `worker2 did not exit normally. exited\
with signal ${signal}`);
Copy link
Member

@jasnell jasnell Oct 16, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The basic change is good but we try to avoid using multi-line template literals in core. This can be improved by...

      assert.strictEqual(code, 0, 
                         'worker2 did not exit normally.' +
                         `exited with code ${code}`);
      assert.strictEqual(signal, null,
                         'worker2 did not exit normally. ' +
                         `exited with signal ${signal}`);

Copy link
Member

@jasnell jasnell Oct 16, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That can be fixed on landing tho :-)

worker1.disconnect();
});
}));

worker1.on('exit', common.mustCall((code, signal) => {
assert.strictEqual(code, 0, 'worker1 did not exit normally');
assert.strictEqual(signal, null, 'worker1 did not exit normally');
assert.strictEqual(code, 0, `worker1 did not exit normally. exited with\
code ${code}`);
assert.strictEqual(signal, null, `worker1 did not exit normally. exited\
with signal ${signal}`);
}));
} else {
const net = require('net');
Expand Down