Skip to content

meta: note re author check in COLLABORATOR_GUIDE #16360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

meta: note re author check in COLLABORATOR_GUIDE #16360

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions COLLABORATOR_GUIDE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,6 +452,15 @@ Check number of commits and commit messages
$ git log upstream/master...master
```

If you land somebody else's PR (especially a first-time contributor's PR),
please make sure that a username and an email in the log match the ones
in the author's GitHub account. Otherwise, the commits will not be properly
associated with the author's account, and the first-time contributor
will not be promoted to Contributor once their first commit is landed.
If in doubt, please contact the author before landing, then abort and reapply
the patch if the author has changed their username and email
and amended the PR commit.

If there are multiple commits that relate to the same feature or
one with a feature and separate with a test for that feature,
you'll need to use `squash` or `fixup`:
Expand Down