Skip to content

http2: remove non-existent pushStream weight option #16451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sebdeckers wants to merge 1 commit into from
Closed

http2: remove non-existent pushStream weight option #16451

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
http2: remove non-existent pushStream weight option 
The PRIORITY field is only supported by HTTP/2 in a HEADERS frame initiated by the client, not in a push request sent by the server.

Documents the recommended approach to set a silent priority as used internally by nghttp2.
  • Loading branch information
@sebdeckers
sebdeckers committed Oct 24, 2017
commit 7d7bc202552ff66c90ee5631270cdd114469852b
7 changes: 4 additions & 3 deletions doc/api/http2.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -964,9 +964,6 @@ added: v8.4.0
Defaults to `false`.
* `parent` {number} Specifies the numeric identifier of a stream the newly
created stream is dependent on.
* `weight` {number} Specifies the relative dependency of a stream in relation
to other streams with the same `parent`. The value is a number between `1`
and `256` (inclusive).
* `callback` {Function} Callback that is called once the push stream has been
initiated.
* Returns: {undefined}
Expand All @@ -987,6 +984,10 @@ server.on('stream', (stream) => {
});
```

Setting the weight of a push stream is not allowed in the `HEADERS` frame. Pass
a `weight` value to `http2stream.priority` with the `silent` option set to
`true` to enable server-side bandwidth balancing between concurrent streams.

#### http2stream.respond([headers[, options]])
<!-- YAML
added: v8.4.0
Expand Down