Skip to content

Conversation

gibfahn
Copy link
Member

@gibfahn gibfahn commented Oct 31, 2017

I assume they aren't meant to be there.

Refs: #15685

cc/ @jasnell

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test, http2

I assume they aren't meant to be there.

Refs: nodejs#15685
@gibfahn gibfahn added http2 Issues or PRs related to the http2 subsystem. test Issues and PRs related to the tests. labels Oct 31, 2017
Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

MylesBorins pushed a commit that referenced this pull request Oct 31, 2017
I assume they aren't meant to be there.

PR-URL: #16631
Refs: #15685
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@MylesBorins
Copy link
Contributor

landed in 889f42a

@gibfahn gibfahn mentioned this pull request Oct 31, 2017
@gibfahn gibfahn deleted the empty-comments-8.x branch October 31, 2017 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

http2 Issues or PRs related to the http2 subsystem. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants