Skip to content

loader, docs, test: named exports from commonjs modules #16675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
devsnek wants to merge 13 commits into from
Closed

loader, docs, test: named exports from commonjs modules #16675

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
81fef20
loader,docs,test: set named exports based on keys from `module.exports`
devsnek Nov 1, 2017
d3647dd
add test for exporting reserved keywords from cjs from esm
devsnek Nov 2, 2017
e8478e2
Slight change of plan with loading (use well-defined __esModule)
devsnek Nov 2, 2017
116b470
Symbol('esModule') exported from `module` builtin
devsnek Nov 2, 2017
1a53fd1
remove comment i forgot to remove
devsnek Nov 2, 2017
ac2b4a1
change up symbol usage, use for(;;), add tests
devsnek Nov 2, 2017
4a1c95a
symbol overrides __esModule
devsnek Nov 2, 2017
49add2b
add back docs for json/c++ addons
devsnek Nov 3, 2017
28f58f6
apparently this is much faster
devsnek Nov 3, 2017
c6da711
this is why you don't commit from github web
devsnek Nov 3, 2017
1220d06
make tests a bit more verbose
devsnek Nov 4, 2017
fe73e26
fix lint
devsnek Nov 4, 2017
c4a6c27
document builtin default export
devsnek Nov 4, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove comment i forgot to remove
  • Loading branch information
@devsnek
devsnek committed Nov 2, 2017
commit 1a53fd195ad58ff16e9c391fa1d9d3a8a3969e70
2 changes: 0 additions & 2 deletions lib/internal/loader/ModuleRequest.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,6 @@ loaders.set('esm', async (url) => {
});

// Strategy for loading a node-style CommonJS module
// Uses babel and typescript style __esModule property for
// attaching named imports due to the possiblity of `module.exports.default`
loaders.set('cjs', async (url) => {
debug(`Loading CJSModule ${url}`);
const CJSModule = require('module');
Expand Down