Skip to content

doc: improve collaborator guide, doc fast-tracking process #17056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

doc: improve collaborator guide, doc fast-tracking process #17056

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
546cea1
doc: reorganize collaborator guide
joyeecheung Nov 15, 2017
d5b3ce8
doc: document the fast-tracking process
joyeecheung Nov 15, 2017
75902aa
[squash] reword and moving paragraphs to better places
joyeecheung Nov 16, 2017
00f7b9f
[squash] remove bug-fix and optimizations as fast-tracking examples, …
joyeecheung Nov 16, 2017
d793f21
[squash] reword fast-track requirements
joyeecheung Nov 17, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[squash] remove bug-fix and optimizations as fast-tracking examples, … 
…change to 2 approvals
  • Loading branch information
@joyeecheung
joyeecheung committed Nov 16, 2017
commit 00f7b9f5ff4e7402eb72c965706385bf6b5cec4f
4 changes: 1 addition & 3 deletions COLLABORATOR_GUIDE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,15 +124,13 @@ week and 72 hours over weekends to account for international time
differences and work schedules. However, certain types of pull requests
can be fast-tracked and may be landed after a shorter delay:

* Trivial changes, for example, those fixing minor bugs or improving
performance without affecting API or causing other wide-reaching impact.
* Focused changes that affect only documentation and/or the test suite.
`code-and-learn` and `good-first-issue` pull requests typically fall
into this category.
* Changes that revert commit(s) and/or fix regressions.

When a pull request is deemed suitable to be fast-tracked, label it with
`fast-track`. The pull request can be landed once more than 3 collaborators
`fast-track`. The pull request can be landed once more than 2 collaborators
Copy link
Member

@tniessen tniessen Nov 16, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be 2 or more then. LGTM otherwise.

approve both the pull request and the fast-tracking request.

### Testing and CI
Expand Down