Skip to content

refac: refactor test-http-response-multiheaders.js test to use countdown #17419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

refac: refactor test-http-response-multiheaders.js test to use countdown #17419

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8365fc7
refac: refactor test-http-response-multiheaders to use countdown
Dec 3, 2017
6e9f719
refac: introduce a variable to store count of runs
Dec 3, 2017
afacc3e
refac: move a variable outside of server listener
Dec 4, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
refac: move a variable outside of server listener
  • Loading branch information
hmammedzadeh committed Dec 4, 2017
commit afacc3e0f081fb8e29fe667abd0ee9720fafb36f
2 changes: 1 addition & 1 deletion test/parallel/test-http-response-multiheaders.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ const norepeat = [
'age',
'expires'
];
const runCount = 2;

const server = http.createServer(function(req, res) {
const num = req.headers['x-num'];
Expand All @@ -48,7 +49,6 @@ const server = http.createServer(function(req, res) {
});

server.listen(0, common.mustCall(function() {
const runCount = 2;
const countdown = new Countdown(runCount, () => server.close());
for (let n = 1; n <= runCount; n++) {
// this runs twice, the first time, the server will use
Expand Down