Skip to content

build: remove bench-* targets #18150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

build: remove bench-* targets #18150

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 4 additions & 48 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1020,57 +1020,13 @@ ifeq ($(XZ), 0)
ssh $(STAGINGSERVER) "touch nodejs/$(DISTTYPEDIR)/$(FULLVERSION)/$(TARNAME)-$(OSTYPE)-$(ARCH).tar.xz.done"
endif

.PHONY: bench-net
bench-net: all
@$(NODE) benchmark/run.js net

bench-crypto: all
@$(NODE) benchmark/run.js crypto

.PHONY: bench-tls
bench-tls: all
@$(NODE) benchmark/run.js tls

.PHONY: bench-http
bench-http: all
@$(NODE) benchmark/run.js http

.PHONY: bench-fs
bench-fs: all
@$(NODE) benchmark/run.js fs

.PHONY: bench-misc
bench-misc: benchmark/misc/function_call/build/Release/binding.node
@$(NODE) benchmark/run.js misc

.PHONY: bench-array
bench-array: all
@$(NODE) benchmark/run.js arrays

.PHONY: bench-buffer
bench-buffer: all
@$(NODE) benchmark/run.js buffers

bench-url: all
@$(NODE) benchmark/run.js url

bench-events: all
@$(NODE) benchmark/run.js events

bench-util: all
@$(NODE) benchmark/run.js util

bench-dgram: all
@$(NODE) benchmark/run.js dgram

.PHONY: bench-all
bench-all: bench bench-misc bench-array bench-buffer bench-url bench-events bench-dgram bench-util
bench-all:
@echo "Please use benchmark/run.js or benchmark/compare.js to run the benchmarks."

.PHONY: bench
bench: bench-net bench-http bench-fs bench-tls

.PHONY: bench-ci
bench-ci: bench
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like bench-ci got completely removed -- should it also get the "deprecation warning"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI is not using bench-ci so I think the chance of anyone using it is much smaller...

bench:
@echo "Please use benchmark/run.js or benchmark/compare.js to run the benchmarks."

.PHONY: lint-md-clean
lint-md-clean:
Expand Down