Skip to content

fs: add promises API #18297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jasnell wants to merge 4 commits into from
Closed

fs: add promises API #18297

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
05e44b3
src: handle exceptions in env->SetImmediates
jasnell Jan 26, 2018
18d0261
fs: add FSReqPromise
jasnell Jan 19, 2018
d4c93e8
fs: add FileHandle object fd wrapper
jasnell Jan 19, 2018
2f150c9
fs: add initial set of fs.promises APIs
jasnell Jan 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions benchmark/fs/bench-stat-promise.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
'use strict';

const common = require('../common');
const fs = require('fs');

const bench = common.createBenchmark(main, {
n: [20e4],
Copy link
Contributor

@psmarshall psmarshall Feb 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could just be 2e5?

Copy link
Member Author

@jasnell jasnell Feb 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. There are a couple like this in the benchmark suite. I'll update those all separately.

statType: ['fstat', 'lstat', 'stat']
});

async function run(n, statType) {
const arg = statType === 'fstat' ?
await fs.promises.open(__filename, 'r') : __filename;
let remaining = n;
bench.start();
while (remaining-- > 0)
await fs.promises[statType](arg);
bench.end(n);

if (typeof arg.close === 'function')
await arg.close();
}

function main(conf) {
const n = conf.n >>> 0;
const statType = conf.statType;
run(n, statType).catch(console.log);
}
Loading