Skip to content

v8: add missing ',' in OpenBSD's 'sources' section #18448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

v8: add missing ',' in OpenBSD's 'sources' section #18448

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
09134e5
v8: add missing ',' in OpenBSD's 'sources' section. Add
qbit Jan 30, 2018
f55b677
build: add cflags for OpenBSD, remove stray comma.
qbit Jan 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
build: add cflags for OpenBSD, remove stray comma.
  • Loading branch information
@qbit
qbit committed Jan 30, 2018
commit f55b677db1fae641c896d3c99bfbc4ae2df686c8
3 changes: 2 additions & 1 deletion common.gypi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,7 @@
],
}],
[ 'OS in "linux freebsd openbsd solaris aix"', {
'cflags': [ '-pthread', ],
'cflags': [ '-pthread' ],
'ldflags': [ '-pthread' ],
}],
[ 'OS in "linux freebsd openbsd solaris android aix cloudabi"', {
Expand All @@ -301,6 +301,7 @@
'standalone_static_library': 1,
}],
['OS=="openbsd"', {
'cflags': [ '-I/usr/local/include' ],
'ldflags': [ '-Wl,-z,wxneeded' ],
}],
],
Expand Down