Skip to content

stream: defer readable when sync #18515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mafintosh wants to merge 3 commits into from
Closed

stream: defer readable when sync #18515

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1f480f6
stream: add failing pipe test
mafintosh Feb 3, 2018
591a1c5
stream: add failing pause -> resume -> pause test
mafintosh Feb 3, 2018
a83008a
stream: defer readable and flow when sync
mafintosh Feb 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
stream: defer readable and flow when sync
  • Loading branch information
@mafintosh
mafintosh committed Feb 5, 2018
commit a83008a35235c8559502eb9accc735a183fb7e0c
17 changes: 12 additions & 5 deletions lib/_stream_readable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -486,11 +486,18 @@ function onEofChunk(stream, state) {
}
state.ended = true;

// emit 'readable' now to make sure it gets picked up.
state.needReadable = false;
if (!state.emittedReadable) {
state.emittedReadable = true;
emitReadable_(stream);
if (state.sync && state.length) {
// if we are sync and have data in the buffer, wait until next tick
// to emit the data. otherwise we risk emitting data in the flow()
// the readable code triggers during a read() call
emitReadable(stream);
} else {
// emit 'readable' now to make sure it gets picked up.
state.needReadable = false;
if (!state.emittedReadable) {
state.emittedReadable = true;
emitReadable_(stream);
}
}
}

Expand Down