Skip to content

test: do not check TXT content in test-dns-any #18547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joyeecheung wants to merge 1 commit into from
Closed

test: do not check TXT content in test-dns-any #18547

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions test/internet/test-dns-any.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,9 +59,6 @@ const checkers = {
checkTXT(r) {
assert.ok(Array.isArray(r.entries));
assert.ok(r.entries.length > 0);
r.entries.forEach((txt) => {
Copy link
Contributor

@apapirovski apapirovski Feb 4, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about something like:

assert(r.entries.some(txt => txt.startsWith('v=spf1')));

Copy link
Member Author

@joyeecheung joyeecheung Feb 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem is the records will be in different 'r's, instead of different entries in the same 'r' (probably something we need to fix, though should be in another PR IMO

assert(txt.startsWith('v=spf1'));
});
assert.strictEqual(r.type, 'TXT');
},
checkSOA(r) {
Expand Down