Skip to content

readline: use Date.now() and move test to parallel #18563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
apapirovski wants to merge 3 commits into from
+81 −114
Closed

readline: use Date.now() and move test to parallel #18563

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eda075e
readline: use Date.now() and move test to parallel
apapirovski Feb 4, 2018
81ce2d1
fixup: don't early assign the value
apapirovski Feb 4, 2018
85ec7bc
fixup: crlfDelay to Infinity
apapirovski Feb 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup: crlfDelay to Infinity
  • Loading branch information
@apapirovski
apapirovski committed Feb 4, 2018
commit 85ec7bce4e48c0202564b7756cc2573bf9cda8d1
8 changes: 6 additions & 2 deletions test/parallel/test-readline-interface.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,6 @@ class FakeInput extends EventEmitter {
end() {}
}

const crlfDelay = common.platformTimeout(1000);

function isWarned(emitter) {
for (const name in emitter) {
const listeners = emitter[name];
Expand Down Expand Up @@ -872,6 +870,12 @@ function isWarned(emitter) {
}
});

// For the purposes of the following tests, we do not care about the exact
// value of crlfDelay, only that the behaviour conforms to what's expected.
// Setting it to Infinity allows the test to succeed even under extreme
// CPU stress.
const crlfDelay = Infinity;

[ true, false ].forEach(function(terminal) {
// sending multiple newlines at once that does not end with a new line
// and a `end` event(last line is)
Expand Down