deps: patch V8 to 6.4.388.42 #18578
Closed
deps: patch V8 to 6.4.388.42 #18578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
v8 engine
Contributor
Author
targos
approved these changes
Feb 5, 2018
cjihrig
approved these changes
Feb 5, 2018
Contributor
Author
|
If everything is green could we fastrack? |
Contributor
Author
|
@nodejs/build odroid is failing during compilation of openssl |
Member
Try again, maybe? The problematic host (1 of 3) is now offline so hopefully it will work this time? |
BridgeAR
approved these changes
Feb 6, 2018
BridgeAR
added
the
author ready
MylesBorins
added a commit
to MylesBorins/node
that referenced
this pull request
Feb 7, 2018
PR-URL: nodejs#18578 Refs: v8/v8@6.4.388.41...6.4.388.42 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Contributor
Author
|
landed in d0e4d4e |
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
PR-URL: nodejs#18578 Refs: v8/v8@6.4.388.41...6.4.388.42 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: v8/v8@6.4.388.41...6.4.388.42