Skip to content

stream: always defer readable in EOF when sync #18615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mcollina wants to merge 2 commits into from
Closed

stream: always defer readable in EOF when sync #18615

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7465b32
stream: always defer readable in EOF when sync
mcollina Feb 7, 2018
d627429
nit
mcollina Feb 7, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/_stream_readable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -488,7 +488,7 @@ function onEofChunk(stream, state) {
}
state.ended = true;

if (state.sync && state.length) {
if (state.sync) {
// if we are sync and have data in the buffer, wait until next tick
Copy link
Member

@mafintosh mafintosh Feb 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prob wanna remove the "and have data in the buffer" part of the comment now

Copy link
Member Author

@mcollina mcollina Feb 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

// to emit the data. otherwise we risk emitting data in the flow()
// the readable code triggers during a read() call
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-stream-readable-object-multi-push-async.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ const BATCH = 10;
});

readable.on('end', common.mustCall(() => {
assert.strictEqual(nextTickPassed, false);
assert.strictEqual(nextTickPassed, true);
}));
}

Expand Down