Skip to content

doc: stricter no-multiple-empty-lines rule #18747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

doc: stricter no-multiple-empty-lines rule #18747

wants to merge 1 commit into from

Conversation

BridgeAR
Copy link
Member

This reduces the maximum line number in the no-multiple-empty-lines eslint rule to 1 for the docs.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

@BridgeAR
doc: activate no-multiple-empty-lines rule
2c5cf8e 
This enables the `no-multiple-empty-lines` eslint rule for the docs.
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. vm Issues and PRs related to the vm subsystem. labels Feb 13, 2018
@BridgeAR
Copy link
Member Author

Light-CI https://ci.nodejs.org/job/node-test-commit-light/260/

@BridgeAR BridgeAR added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. blocked PRs that are blocked by other issues or PRs. and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Feb 13, 2018
@BridgeAR
Copy link
Member Author

Blocked by #18758

@BridgeAR BridgeAR added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed blocked PRs that are blocked by other issues or PRs. labels Feb 16, 2018
@BridgeAR
Copy link
Member Author

New CI rebased to origin/master https://ci.nodejs.org/job/node-test-commit-light/277/

@BridgeAR
Copy link
Member Author

Landed in 69f7ce9

@BridgeAR BridgeAR closed this Feb 16, 2018
BridgeAR added a commit to BridgeAR/node that referenced this pull request Feb 16, 2018
@BridgeAR
doc: activate no-multiple-empty-lines rule
69f7ce9 
This enables the `no-multiple-empty-lines` eslint rule for the docs.

PR-URL: nodejs#18747
Reviewed-By: Weijia Wang <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@BridgeAR @MylesBorins
doc: activate no-multiple-empty-lines rule
a14186b 
This enables the `no-multiple-empty-lines` eslint rule for the docs.

PR-URL: #18747
Reviewed-By: Weijia Wang <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Feb 21, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@BridgeAR @MylesBorins
doc: activate no-multiple-empty-lines rule
c569f70 
This enables the `no-multiple-empty-lines` eslint rule for the docs.

PR-URL: #18747
Reviewed-By: Weijia Wang <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@BridgeAR @MylesBorins
doc: activate no-multiple-empty-lines rule
cd2fa04 
This enables the `no-multiple-empty-lines` eslint rule for the docs.

PR-URL: #18747
Reviewed-By: Weijia Wang <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@BridgeAR @MayaLekova
doc: activate no-multiple-empty-lines rule
c956636 
This enables the `no-multiple-empty-lines` eslint rule for the docs.

PR-URL: nodejs#18747
Reviewed-By: Weijia Wang <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
MylesBorins pushed a commit that referenced this pull request Aug 7, 2018
@BridgeAR @MylesBorins
doc: activate no-multiple-empty-lines rule
b4fa857 
This enables the `no-multiple-empty-lines` eslint rule for the docs.

PR-URL: #18747
Reviewed-By: Weijia Wang <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
MylesBorins pushed a commit that referenced this pull request Aug 7, 2018
@BridgeAR @MylesBorins
doc: activate no-multiple-empty-lines rule
4e2241e 
This enables the `no-multiple-empty-lines` eslint rule for the docs.

PR-URL: #18747
Reviewed-By: Weijia Wang <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
MylesBorins pushed a commit that referenced this pull request Aug 7, 2018
@BridgeAR @MylesBorins
doc: activate no-multiple-empty-lines rule
e7cccf3 
This enables the `no-multiple-empty-lines` eslint rule for the docs.

PR-URL: #18747
Reviewed-By: Weijia Wang <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
MylesBorins pushed a commit that referenced this pull request Aug 9, 2018
@BridgeAR @MylesBorins
doc: activate no-multiple-empty-lines rule
6cd23c2 
This enables the `no-multiple-empty-lines` eslint rule for the docs.

PR-URL: #18747
Reviewed-By: Weijia Wang <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Aug 16, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Aug 16, 2018
@BridgeAR @MylesBorins
doc: activate no-multiple-empty-lines rule
ebd73ad 
This enables the `no-multiple-empty-lines` eslint rule for the docs.

PR-URL: #18747
Reviewed-By: Weijia Wang <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
@BridgeAR BridgeAR deleted the no-multiline-docs branch April 1, 2019 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

+2 more reviewers

@mmarchini mmarchini mmarchini approved these changes

@starkwang starkwang starkwang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. vm Issues and PRs related to the vm subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@BridgeAR @jasnell @lpinca @cjihrig @mmarchini @starkwang @MylesBorins @nodejs-github-bot