src: fix the returned Promise of fs.promises.symlink #18791
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
evanlucas
approved these changes
Feb 15, 2018
cjihrig
approved these changes
Feb 15, 2018
Contributor
cjihrig
left a comment
cjihrig
left a comment
There was a problem hiding this comment.
Is there a test that can be added for this?
Member
|
Note that this conflicts with #18777 Also +1 on adding a test |
benjamingr
approved these changes
Feb 15, 2018
jasnell
approved these changes
Feb 15, 2018
Author
|
Do you mean a test for |
joyeecheung
reviewed
Feb 16, 2018
| if (req_wrap != nullptr) { // symlink(target, path, flags, req) | ||
| AsyncDestCall(env, req_wrap, args, "symlink", *path, path.length(), UTF8, | ||
| AfterNoArgs, uv_fs_symlink, *target, *path, flags); | ||
| req_wrap->SetReturnValue(args); |
Member
There was a problem hiding this comment.
It is not safe to call req_wrap->SetReturnValue(args) like this without checking if the pointer returned by AsyncDestCall is nullptr, see #18811 (that PR just calls SetReturnValue () inside AsyncDestCall so the binding do not have to touch req_wrap)
Author
There was a problem hiding this comment.
I see, thank you for the information!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Cf. #18674
I added missing
req_wrap->SetReturnValue(args);in Symlink of node_file.cc.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
src, fs